<     May 2017     >
Su Mo Tu We Th Fr Sa  
    1  2  3  4  5  6  
 7  8  9 10 11 12 13  
14 15 16 17 18 19 20  
21 22 23 24 25 26 27  
28 _2_9 30 31
01:00 glennpratt joined
01:10 glennpratt joined
01:33 glennpratt joined
01:43 GitHub133 joined
01:43 <GitHub133> [13sequel] 15xyhc commented on issue #1350: thanks ! ... 02https://git.io/v9PHJ
01:43 GitHub133 left
02:06 <bougyman> 42
02:31 glennpratt joined
02:37 glennpratt joined
07:38 ernlyne joined
08:21 aidalgol joined
09:02 GitHub199 joined
09:02 <GitHub199> [13sequel] 15AlexWayfer opened issue #1353: String in schema modification documentation 02https://git.io/v9XGB
09:02 GitHub199 left
11:06 ta_ joined
11:59 ta_ joined
13:57 glennpratt joined
14:10 GitHub131 joined
14:10 <GitHub131> [13sequel] 15jeremyevans commented on issue #1353: The code example shows Sequel's defaults. The PostgreSQL support overrides the defaults. I think it is unreasonable to document all cases where database adapters override the defaults in the schema modification guide.... 02https://git.io/v9XxT
14:10 GitHub131 left
14:10 GitHub114 joined
14:10 <GitHub114> [13sequel] 15jeremyevans closed issue #1353: String in schema modification documentation 02https://git.io/v9XGB
14:10 GitHub114 left
14:30 glennpratt joined
15:42 GitHub12 joined
15:42 <GitHub12> [13sequel] 15AlexWayfer commented on issue #1353: Sorry, did not notice this text.... 02https://git.io/v91nM
15:42 GitHub12 left
17:04 tercenya joined
17:07 GitHub178 joined
17:07 <GitHub178> [13sequel] 15jeremyevans commented on issue #1351: Please only do this on oracle, as I showed in my earlier example. Also, for the `nvarchar2`, just adding a `2?` after the existing `n?varchar` seems simpler. With those changes and this rebased into a single commit, it should be ready for merging. Thanks! 02https://git.io/v91Xw
17:07 GitHub178 left
17:10 GitHub191 joined
17:10 <GitHub191> [13sequel] 15jeremyevans commented on issue #1353: I don't think it makes sense to list the defaults for each database type. Sequel supports around 11 database types just in the adapters that ship with it, and external adapters would have their own behavior.... 02https://git.io/v911J
17:10 GitHub191 left
17:26 GitHub87 joined
17:26 <GitHub87> [13sequel] 15StevenCregan commented on issue #1351: From my testing, schema[:db_type] returns the datatype, not the type of database. Not sure what's going on there 02https://git.io/v91Dc
17:26 GitHub87 left
17:32 GitHub103 joined
17:32 <GitHub103> [13sequel] 15jeremyevans commented on issue #1351: If you look at my code example, I'm calling the `db_type` method to get the database type symbol. 02https://git.io/v91yO
17:32 GitHub103 left
17:38 GitHub62 joined
17:38 <GitHub62> [13sequel] 15StevenCregan commented on issue #1351: Thanks for clarifying, I'll adjust 02https://git.io/v91Ss
17:38 GitHub62 left
18:01 GitHub53 joined
18:01 <GitHub53> [13sequel] 15jeremyevans commented on issue #1351: `(2)?` in regexp creates an extra capturing group. Please use `2?` as previously recommended. With that fixed and this squashed to a single commit, I should be able to merge later today. 02https://git.io/v917W
18:01 GitHub53 left
18:03 GitHub42 joined
18:03 <GitHub42> [13sequel] 15StevenCregan commented on issue #1351: Sorry. Also, changing to reference `:db_type` has caused other tests to fail, I should not have pushed that yet 02https://git.io/v9177
18:03 GitHub42 left
18:06 GitHub17 joined
18:06 <GitHub17> [13sequel] 15StevenCregan commented on issue #1351: Sorry. Also, changing to reference `:db_type` has caused other tests to fail, I should not have pushed that yet 02https://git.io/v9177
18:06 GitHub17 left
18:17 tercenya joined
18:43 plujon joined
19:05 GitHub112 joined
19:05 <GitHub112> [13sequel] 15AlexWayfer commented on issue #1353: Okay, thank you. 02https://git.io/v91j1
19:05 GitHub112 left
19:11 GitHub11 joined
19:11 <GitHub11> [13sequel] 15StevenCregan commented on issue #1351: After changing to check against :db_type == :oracle, it no longer works. I'm not sure what needs to change in order to fix the behavior 02https://git.io/v9Me0
19:11 GitHub11 left
19:49 GitHub41 joined
19:49 <GitHub41> [13sequel] 15jeremyevans commented on issue #1351: `:db_type == :oracle` is always going to be false. However, the code example I gave is bad, as the method is named `database_type`, not `db_type`. Changing `:db_type` to `database_type` should fix things. 02https://git.io/v9MU5
19:49 GitHub41 left
22:01 tercenya joined
23:53 glennpratt joined