<     May 2017     >
Su Mo Tu We Th Fr Sa  
    1  2  3  4  5  6  
 7  8  9 10 11 12 13  
14 15 16 17 18 19 20  
21 22 23 24 25 26 27  
28 29 30 31
00:25 glennpratt joined
00:33 glennpratt joined
00:35 glennpratt joined
01:22 glennpratt joined
02:32 glennpratt joined
03:46 glennpratt joined
03:49 claw joined
04:32 glennpratt joined
05:38 GitHub71 joined
05:38 <GitHub71> [13sequel] 15perlun opened pull request #1360: CONTRIBUTING: Fixed typos (06master...06patch-1) 02https://git.io/v9bve
05:38 GitHub71 left
05:42 GitHub140 joined
05:42 <GitHub140> [13sequel] 15perlun commented on issue #1358: > This isn't a bug, it's expected that an error would be logged in this case, since the query raises an exception. table_exists? is implemented by trying to select from the table, and returning false if doing so raises a DatabaseError.... 02https://git.io/v9bvO
05:42 GitHub140 left
05:44 GitHub172 joined
05:44 <GitHub172> [13sequel] 15perlun commented on issue #1357: > I don't think littering the codebase with defensive error checks for nicer error messages is a worthy trade off.... 02https://git.io/v9bvC
05:44 GitHub172 left
05:53 GitHub166 joined
05:53 <GitHub166> [13sequel] 15perlun commented on issue #1357: (Another way I thought of if we want to do something about this ourselves but still not destroy the simplicity of our code is to implement our own `Sequel#merge_hash` method or something, that will have this kind of error checking built-in. That way we can call that method instead of `Hash#merge` consistently, and get it in all places where it would be useful. It would feel like a reasonable compromise
05:53 GitHub166 left
07:34 ta_ joined
09:35 lopex joined
12:56 ged joined
12:57 mahlon joined
13:53 banditron joined
14:14 glennpratt joined
14:37 ben_____ joined
14:56 GitHub128 joined
14:56 <GitHub128> [13sequel] 15jeremyevans commented on issue #1360: Looks good, thanks for the patch! 02https://git.io/v9bhP
14:56 GitHub128 left
14:58 GitHub33 joined
14:58 <GitHub33> [13sequel] 15jeremyevans pushed 1 new commit to 06master: 02https://git.io/v9bhF
14:58 <GitHub33> 13sequel/06master 147f4d8ca 15Per Lundberg: CONTRIBUTING: Fixed typos
14:58 GitHub33 left
14:58 GitHub144 joined
14:58 <GitHub144> [13sequel] 15jeremyevans closed pull request #1360: CONTRIBUTING: Fixed typos (06master...06patch-1) 02https://git.io/v9bve
14:58 GitHub144 left
15:00 GitHub163 joined
15:00 <GitHub163> [13sequel] 15jeremyevans commented on issue #1357: No, as that still adds defensive error checking, it just centralizes it. Less litter I suppose, but the objection still applies. I still think you should try to upstream the improvement to the error message if you think it should be changed. 02https://git.io/v9bj8
15:00 GitHub163 left
15:59 tercenya joined
16:37 tercenya joined
17:28 tercenya joined
18:47 tercenya joined
19:01 tercenya joined
20:14 ta_ joined
21:34 tercenya joined
22:00 tercenya joined
23:40 glennpratt joined
23:45 glennpratt joined
23:48 glennpratt joined